make status notifications minimal #162
Conversation
| (* if we have a DM notification, we don't need to repeat the commit message and author because | ||
| the user receiving the message is already the author of that commit. Users handles start with U *) |
There was a problem hiding this comment.
we even never need to have duplicated information?
There was a problem hiding this comment.
On the channel notifications we could remove the duplicate commit message and keep only the author. I kept it for the sake of the format we had before, but I think it's ok to remove the duplicate commit message entirely
| commit.author.name author); | ||
| (* if we have a DM notification, we don't need to repeat the commit message and author because | ||
| the user receiving the message is already the author of that commit. Users handles start with U *) | ||
| (match Devkit.Stre.starts_with channel "U" with |
There was a problem hiding this comment.
hum, you are right. Should update to use a regular expression. Ids in slack start with U for users and C for channels, so that was my reasoning, but since we don't use # prefixes when declaring slack channels, it is better to go with the regexp.
There was a problem hiding this comment.
can't we use an actual type instead?
There was a problem hiding this comment.
we can, it's probably a good idea, but it forces changes in a lot of places and more or less repeated, I'll have another pass at the code to see if I can refactor the rule matching in some way to minimize the places where we need to make these changes. If it's not possible, then need to make the changes in all the places that get the channels list for the notifications
|
merging as it restores the quick feedback loop, can iterate on message format in another PR |
After merging and deploying #160 we realized that we need faster feedback and thus can't wait for a full build to finish.
We need to get slack notifications on the
build is failinggh notification. This means that when we get the gh notification we don't have any certainty about which steps will fail in that build, we only know one for certain that something has failed and that the whole pipeline will have a failed build at the end.So we discussed and opted for making the notifications as minimal as possible.
example success notification:
DM notification doesn't have repeated commit message or author, since the author is the user receiving the message
updated tests