handle multi-step states #156
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Khady
reviewed
Aug 8, 2024
| @@ -33,7 +33,7 @@ jobs: | |||
| # apt update is implicit | |||
| # pinning package implicit | |||
| # depext install implicit | |||
| - run: opam install . ocamlformat.0.20.1 | |||
| - run: opam install . ocamlformat.0.26.2 | |||
There was a problem hiding this comment.
this kind of change should go to master directly
Khady
approved these changes
Aug 8, 2024
lib/state.ml
Outdated
Comment on lines
57
to
58
| (* when new jobs are pending, we keep the existing state *) | ||
| | Pending -> current_build_status.original_failed_commit, current_build_status.current_failed_commit |
There was a problem hiding this comment.
Suggested change
| (* when new jobs are pending, we keep the existing state *) | |
| | Pending -> current_build_status.original_failed_commit, current_build_status.current_failed_commit | |
| | (* when new jobs are pending, we keep the existing state *) Pending -> | |
| current_build_status.original_failed_commit, current_build_status.current_failed_commit |
Suggested change
| (* when new jobs are pending, we keep the existing state *) | |
| | Pending -> current_build_status.original_failed_commit, current_build_status.current_failed_commit | |
| | Pending (* when new jobs are pending, we keep the existing state *) -> | |
| current_build_status.original_failed_commit, current_build_status.current_failed_commit |
Suggested change
| (* when new jobs are pending, we keep the existing state *) | |
| | Pending -> current_build_status.original_failed_commit, current_build_status.current_failed_commit | |
| | Pending -> | |
| (* when new jobs are pending, we keep the existing state *) | |
| current_build_status.original_failed_commit, current_build_status.current_failed_commit |
nitpick, but I find it easier to read the comments when they are inside the branch they are about
There was a problem hiding this comment.
makes sense. Moved the comment inside, as per the last of your suggestions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the task
This PR sets the base layer to handle multi-step states. From here we can keep track of builds that keep failing over time and who created the original failing commit and the latest commit to add on top of that failure.