Improve successes for the ocaml-ci (for OCaml ≤ 4.12 + lower bounds)
#39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rr0gi
approved these changes
Nov 12, 2024
|
This brings the lower bound from 4.13 to 4.12. Next failure is on the |
smondet
force-pushed
the
fix-ci-pre-413
branch
from
6dfda4f to
b4589de
Compare
|
In case anybody is also curious, double-checked that module F (P : sig val x : string end) = struct
let p () = Printf.eprintf "x: %S, f: %S\n%!" P.x __FUNCTION__
end
module G = F(struct let x = "G-arg" end)
module H = F(struct let x = "H-arg" end)
let () =
G.p ();
H.p ();
print_endline "Done." |
smondet
force-pushed
the
fix-ci-pre-413
branch
3 times, most recently
from
8a1d4c8 to
8e2a8d7
Compare
smondet
changed the title
ocaml-ci (for OCaml ≤ 4.12)ocaml-ci (for OCaml ≤ 4.12 + lower bounds)
|
The remaining failures are from |
rr0gi
approved these changes
Nov 13, 2024
web.ml
Outdated
| @@ -301,7 +301,8 @@ module Http (IO : IO_TYPE) (Curl_IO : CURL with type 'a t = 'a IO.t) : HTTP with | |||
| "url.full", `String url; | |||
| ] | |||
| in | |||
| let explicit_span = Possibly_otel.enter_manual_span ~__FUNCTION__ ~__FILE__ ~__LINE__ ~data:describe action_name in | |||
| let explicit_span = | |||
| Possibly_otel.enter_manual_span ~__FUNCTION__:"Web.Http.add_if_absent" ~__FILE__ ~__LINE__ ~data:describe action_name in | |||
There was a problem hiding this comment.
That's what the value __FUNCTION__ gives there right?
There was a problem hiding this comment.
Oops actually not, misread, sorry
There was a problem hiding this comment.
The real value at that location seems to be "Devkit_core__Web.Http.http_request'.(fun)", at least from dune utop ., not sure how it shows up in other build contexts.
smondet
force-pushed
the
fix-ci-pre-413
branch
from
8e2a8d7 to
31632b4
Compare
- `String.starts_with` added in 4.13. - `__FUNCTION__` added in 4.12. - Force version of PCRE bindings (from 2020, OCaml 4.08). - Force version of Lwt (`Lwt.reraise` added in 5.7.0).
smondet
force-pushed
the
fix-ci-pre-413
branch
from
31632b4 to
4ce705f
Compare
rr0gi
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.