New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpev: don't use Unix.SO_ERROR (deprecated) #35

Merged

rr0gi merged 1 commit into master from ahrefs/get-socket-error

Oct 22, 2024

Contributor

ferminr commented Oct 14, 2024 •

edited

Loading

Otherwise, when building locally with ocaml5 (on ubuntu 24.04), the build fails with:

Error (alert deprecated): SO_ERROR
Use Unix.getsockopt_error instead.


          httpev: don't use deprecated value Unix.SO_ERROR

b9e6865

ferminr requested a review from Khady

October 14, 2024 16:30

ferminr mentioned this pull request

Use Stdlib.raise and Lwt.reraise instead of Lwt.fail for better backtraces #36

Merged

rr0gi approved these changes

View reviewed changes

rr0gi merged commit cb6d2c6 into master

2 of 3 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet