Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

web: fix wrong otel parent scope #33

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

tatchi
Copy link
Contributor

@tatchi tatchi commented Oct 11, 2024

We need to set the span in the traceparent header to be the one we explicitly create with Possibly_otel.enter_manual_span

@tatchi tatchi requested review from Khady and rr0gi October 11, 2024 15:48
@tatchi tatchi force-pushed the fix-otel-parent-scope branch from b78f444 to 3cbb4e5 Compare October 12, 2024 19:30
possibly_otel.stub.ml Outdated Show resolved Hide resolved
@tatchi tatchi force-pushed the fix-otel-parent-scope branch from 3cbb4e5 to 24b99df Compare October 14, 2024 07:29
@tatchi tatchi merged commit 9874c73 into ahrefs:master Oct 14, 2024
2 of 3 checks passed
@tatchi tatchi deleted the fix-otel-parent-scope branch October 14, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants