annotation filters with cli arguments #418
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements the suggestion from @tsnobip and @mjambon in #324.
-tag producer -tag res
)<ocaml tag="producer" tag="foo" name="Foo">
)(
<ocaml name="Foo">
is selected by-tag bar
but<ocaml tag="foo" name="Foo">
is not selected by-tag bar
)The tags are currently implemented by removing all attributes from the AST which do not match the cli argument(s).
This is the easiest way I could think of to implement that feature. If there is a better way or this leads to problems, please let me know 🙂
I am not sure, if the schema changes I made, make sense. I just allowed
<... tag="foo">
fields in every attribute location (except for doc attributes).PR checklist
CHANGES.md
is up-to-date