[atddiff] Offer '--no-locations' option #382
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--no-locations
is aimed at producing more stable results that allow diffing successive atddiff reports to spot new findings and ignore old ones.I marked this feature as experimental because it doesn't feel quite right to me. We'll be using it for identifying new findings by comparing the previous atddiff report with the current one in CI. Experience will tell us if it's good enough or if we need something different.
The JSON output format changed. Two records -
full_finding
andfinding
were merged into one,finding
. Here's the atddiff output obtained via git:I think it will be much easier to decipher once we show the snippets of code affected by the findings (feature request #380).
Closes #377
PR checklist
CHANGES.md
is up-to-date