Encode int64 value as string in json codec #231
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
atdgen-runtime
encodesint64
value as JSONnumber
. This makes it difficult to use the resulting JSON in the JavaScript environments (node, browser). For example, consider this issue with theInt64.max_int
value:Right away, some information is lost. If we encode it as string though, we don't have such problem anymore. Moreover decoding already supports string as the transportation format for
int64
(test is added). This change fixes the interoperability with bucklescript ahrefs/melange-atdgen-codec-runtime#22Nevertheless, the change is breaking, so version bump is needed if merged.