Merge pull request #4 from agoda-com/init-modify

feat: modify the defaults to match the style guide
agoda-com · Oct 30, 2019 · b362043 · b362043
2 parents 78c54c1 + 208a6e1
commit b362043
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 9 deletions.
diff --git a/configs/@typescript-eslint/index.js b/configs/@typescript-eslint/index.js
@@ -19,7 +19,7 @@ module.exports = {
   "@typescript-eslint/no-namespace": ["error"],
   "@typescript-eslint/no-non-null-assertion": ["warn"],
   "@typescript-eslint/no-this-alias": ["error"],
-  "@typescript-eslint/no-unused-vars": ["warn"],
+  "@typescript-eslint/no-unused-vars": ["error", { argsIgnorePattern: "_" }],
   "@typescript-eslint/no-use-before-define": ["error"],
   "@typescript-eslint/no-var-requires": ["error"],
   "@typescript-eslint/prefer-namespace-keyword": ["error"],

diff --git a/configs/eslint/index.js b/configs/eslint/index.js
@@ -133,7 +133,7 @@ module.exports = {
       requireReturnForObjectLiteral: false
     }
   ],
-  "arrow-parens": ["error", "always"],
+  "arrow-parens": ["error", "as-needed", { "requireForBlockBody": true }],
   "arrow-spacing": [
     "error",
     {

diff --git a/configs/react/index.js b/configs/react/index.js
@@ -41,10 +41,7 @@ module.exports = {
   ],
   "react/jsx-boolean-value": [
     "error",
-    "never",
-    {
-      always: []
-    }
+    "always"
   ],
   "react/jsx-closing-bracket-location": ["error", "line-aligned"],
   "react/jsx-closing-tag-location": ["error"],
@@ -62,7 +59,7 @@ module.exports = {
       eventHandlerPropPrefix: "on"
     }
   ],
-  "react/jsx-indent-props": ["error", 2],
+  "react/jsx-indent-props": ["error", 4],
   "react/jsx-key": ["off"],
   "react/jsx-max-props-per-line": [
     "error",
@@ -213,7 +210,7 @@ module.exports = {
   ],
   "react/jsx-first-prop-new-line": ["error", "multiline-multiprop"],
   "react/jsx-equals-spacing": ["error", "never"],
-  "react/jsx-indent": ["error", 2],
+  "react/jsx-indent": ["error", 4],
   "react/jsx-no-target-blank": [
     "error",
     {
@@ -329,7 +326,7 @@ module.exports = {
     "error",
     {
       html: "enforce",
-      custom: "enforce",
+      custom: "ignore",
       exceptions: []
     }
   ],