This repository has been archived by the owner on Sep 23, 2024. It is now read-only.
Use context with timeout for external RPC API calls #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stefan-Ethernal
force-pushed
the
CDK-27-configure-context-with-timeout-for-all-external-rpc-calls
branch
from
cd625b4 to
5160c3a
Compare
Stefan-Ethernal
force-pushed
the
CDK-27-configure-context-with-timeout-for-all-external-rpc-calls
branch
from
5160c3a to
875eba7
Compare
begmaroman
reviewed
Dec 15, 2023
begmaroman
approved these changes
Dec 15, 2023
|
goran-ethernal
approved these changes
Dec 15, 2023
Stefan-Ethernal
deleted the
CDK-27-configure-context-with-timeout-for-all-external-rpc-calls
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces
context.WithTimeoutfor theInteropEndpoints, where we are sending requests to some external RPC endpoints. It relies onReadTimeoutfromjsonrpc.Config.It also implements unit tests for
ConvertProof, to meet quality gate, since that code is affected by introducing theHashLengthandProofLengthconstants.