Refactor Talk indexing into a Talk::Index record.

[kaspth]

This does take some extra work since Active Record can't detect rowid is the primary key.

But with some awareness around that, it's pretty smooth sailing and we can entirely remove a lot of the custom SQL with standard Active Record.

[kaspth]

We get this for free now via dependent: :destroy!

[kaspth]

I don't get what's going on in the tests.

In development the query looks correct and finds the talk:

rubyvideo(dev)> Talk.ft_search "Hotwire Cookbook"
  Talk Load (2.3ms)  SELECT "talks".* FROM "talks" INNER JOIN "talks_search_index" ON "talks_search_index"."rowid" = "talks"."id" WHERE (talks_search_index match 'Hotwire* Cookbook*') /* loading for pp */ LIMIT 11 /*application='Rubyvideo'*/

But in tests the query looks different and doesn't find the talk:

SELECT "talks".* FROM "talks" INNER JOIN "talks_search_index" ON "talks_search_index"."rowid" = "talks"."id" WHERE (talks_search_index match ?)  [[nil, "Hotwire* Cookbook*"]]

The [[nil, "Hotwire* Cookbook*"]] structure seems to indicate a bind parameter and potentially a prepared statement, but we don't seem to have that turned on/off anywhere. Maybe it's a Rails default somehow?

Swapping to where("#{table_name} match :query", query:) also doesn't work. Hm, I'm confused.

[kaspth]

Ok, if I put prepared_statements: false in database.yml, I get the same query as in development:

SELECT "talks".* FROM "talks" INNER JOIN "talks_search_index" ON "talks_search_index"."rowid" = "talks"."id" WHERE (talks_search_index match 'Hotwire* Cookbook*')

But it still doesn't find the book.

[kaspth]

Ah, something seems to be up when we try to insert the record, hm. It's missing the rowid here.

INSERT INTO "talks_search_index" ("title", "summary", "speaker_names") VALUES ('yo', '', 'Yauhen Karatkou') RETURNING "rowid" /*application='Rubyvideo'*/

[kaspth]

Ok, wow, maybe this is more trouble than it's worth. We have to drop back into raw SQL to get Active Record to put in the rowid when inserting.

[adrienpoly]

I like how it all feels really ActiveRecord.

[kaspth]

I'm hoping to get back to this, because I'd like to wrap it up.