Discard talk #525
Draft
Discard talk #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marcoroth
reviewed
Dec 16, 2024
| @@ -0,0 +1,6 @@ | |||
| class AddDiscardedAtToTalks < ActiveRecord::Migration[8.0] | |||
| def change | |||
| add_column :talks, :discarded_at, :datetime | |||
There was a problem hiding this comment.
I feel we should call this something like hidden_at rather than discarded_at, since this feature is more about "hiding" a talk from showing up.
There was a problem hiding this comment.
discarded_at is the attribute used by the gem discard but we could easily do without it with a simple concern.
For me the main question remains do we hide the talk or hide the SpeakerTalk relation
If we hide the relation then some things we wanted to do becomes a bit more tricky
- does appear in the event index view as grayedout (only if all SpeakerTalk are hidden)
- doesn't have a #show page (only if all SpeakerTalk are hidden)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this is a first stab at #372
while implementing the feature and in particular trying the discard the talks from Zzak I realised that since a talk can have multiple speaker (https://www.rubyvideo.dev/talks/building-cli-apps-for-everyone) if a talk is discarded then it will be hidden for all speakers of that talk.
I wonder if we should keep it like that or discard the SpeakerTalk relationship?
close #372