Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace Avahi with ZeroConf for cross platform;add fake LED for testing #27

Closed
wants to merge 5 commits into from

Conversation

ihidchaos
Copy link

  1. Use zeroconf instead of avahi to avoid the need to install additional Linux dependencies and to facilitate the use of this library on Windows.
  2. Add a fake_onoff_led example to facilitate debugging without hardware dependencies.

@ihidchaos ihidchaos changed the title replase Avahi with ZeroConf for cross platform;add fake LED for testing replace Avahi with ZeroConf for cross platform;add fake LED for testing Oct 28, 2024
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! Thank you!

Please run pre-commit to get the nitpicky things fixed for you.

@ihidchaos
Copy link
Author

Neat! Thank you!

Please run pre-commit to get the nitpicky things fixed for you.

I noticed that the CI fails because the following two files are missing copyright information.

Error: # MISSING COPYRIGHT AND LICENSING INFORMATION

The following files have no copyright and licensing information:
* circuitmatter/clusters/measurement/temperature_measurement.py
* circuitmatter/device_types/sensor/temperature_sensor.py

But they were not introduced by my code, but from this commit.
Should I simply add the following statement in front of these two files to pass the CI?

# SPDX-FileCopyrightText: Copyright (c) 2024 Scott Shawcroft for Adafruit Industries
#
# SPDX-License-Identifier: MIT

@tannewt
Copy link
Member

tannewt commented Nov 26, 2024

Should I simply add the following statement in front of these two files to pass the CI?

Lets wait for #26 because I think it'll fix that error.

@lboue
Copy link
Contributor

lboue commented Nov 27, 2024

Should I simply add the following statement in front of these two files to pass the CI?

Lets wait for #26 because I think it'll fix that error.

#26 is merged.

@ihidchaos
Copy link
Author

Should I simply add the following statement in front of these two files to pass the CI?

Lets wait for #26 because I think it'll fix that error.

#26 is merged.

Done.

@ihidchaos ihidchaos marked this pull request as draft November 29, 2024 10:35
@lboue
Copy link
Contributor

lboue commented Dec 16, 2024

@ihidchaos Any news?

@ihidchaos
Copy link
Author

@ihidchaos Any news?

I found some problems in the test on Windows, and I need to modify and test it again. The completion time is to be determined, and I have marked it as a draft.

@lboue
Copy link
Contributor

lboue commented Dec 17, 2024

@ihidchaos Any news?

I found some problems in the test on Windows, and I need to modify and test it again. The completion time is to be determined, and I have marked it as a draft.

Did you try using codespaces as a workaround?

@ihidchaos
Copy link
Author

@ihidchaos Any news?

I found some problems in the test on Windows, and I need to modify and test it again. The completion time is to be determined, and I have marked it as a draft.

Did you try using codespaces as a workaround?

Sorry, after some investigation this is not a Windows platform issue. In fact I found it so difficult to use the python zeroconf library for subtype mdns broadcasts that I decided to give up.

@ihidchaos ihidchaos closed this Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants