-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review PR: Add "Offline" SDLogger Mode #676
Open
brentru
wants to merge
204
commits into
main
Choose a base branch
from
review-mode-sdlogger
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…working fully yet
…rsnapper_V2 class
Use latest build artifacts
New checkin model class added along with functions within .cpp to exec. it
…add dynamic SD CS pin
…ne devices too and eventual cellular
…pplicable to properly indicate its a stub class, add pico to ini
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is not meant to be merged in. It is a review-only pull request for specific regions of code.
Codebase regions for review
ws_sdcard
- for interfacing with a micro SD Card breakout.parseConfigFile
functions and looksBuildJSONDoc
andLogJSONDoc
API interfaces are present for each type of componentws_sdcard
and mode-switching (determining whether the device is online or offline) withinWipperSnapper_V2
class in two functions -provision()
andconnect()
FS_V2
andLittleFS_V2
network_interfaces/
toadapters/
to allow for a WipperSnapper device without a network interface (offline/
).adapters/offline/ws_offline_pico
to support a Raspberry Pi in offline mode.Workflow enhancements for review:
run-tests.yml
, to automate testing using Wokwi.