Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move coverage to separate script #805

Merged
merged 4 commits into from
Nov 7, 2023
Merged

Move coverage to separate script #805

merged 4 commits into from
Nov 7, 2023

Conversation

ncalteen
Copy link
Collaborator

This PR separates the make-coverage-badge call to its own script in package.json, so that running npm run all does not continue when unit tests fail.

Fixes #799

@ncalteen ncalteen self-assigned this Oct 23, 2023
@ncalteen ncalteen mentioned this pull request Oct 23, 2023
Closed
sethrylan
sethrylan approved these changes Nov 7, 2023
View reviewed changes
Copy link

@sethrylan sethrylan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice cleanup!

LGTM

@ncalteen ncalteen merged commit 0d7960b into main Nov 7, 2023
6 checks passed
@ncalteen ncalteen deleted the tests branch November 7, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sethrylan sethrylan sethrylan approved these changes

Assignees

@ncalteen ncalteen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"npm test" script eats failure-status (because "|| make-coverage-badge")
2 participants
@ncalteen @sethrylan