Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Django: Use current versions of Python #2661

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Django: Use current versions of Python #2661

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ci/django.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,12 +13,12 @@ jobs:
strategy:
max-parallel: 4
matrix:
python-version: [3.7, 3.8, 3.9]
python-version: [3.9, 3.11, 3.13]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks ok; 3.9.20+ through 3.13 are all supported still (3.7 & 3.8 are EoL)!

⚠️ Verification:
Consider continuous versions or clarify new version choice.

NIT @cclauss why `3.9` and `3.11` but no `3.10`, and why skip the default `3.12` in the matrix? This is confusing.

I suggest either:

  • Add both 3.10 and 3.12:
Suggested change
python-version: [3.9, 3.11, 3.13]
python-version: ['3.9', '3.10', '3.11', '3.12' '3.13']
  • Add 3.12 instead of 3.9:
Suggested change
python-version: [3.9, 3.11, 3.13]
python-version: ['3.11', '3.12' '3.13']
  • Keep 3.9 but add 3.10 Instead of 3.13:
Suggested change
python-version: [3.9, 3.11, 3.13]
python-version: ['3.9', '3.10', '3.11'] # 3.12 is already installed by default on ubuntu-latest

Important

while perfectly fine for versions pre-3.10 (e.g. 3.9), the github yaml parsing seems to prefer quoted values (e.g. as in python-package.yml) than raw Semantic-Versions (e.g. 🙅 3.11). If these are the intended versions (see previous consideration), then I'd recommend quoting them for consistency.

Suggested change
python-version: [3.9, 3.11, 3.13]
python-version: ["3.9", "3.11", "3.13"]

Copy link
Contributor Author

@cclauss cclauss Dec 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first comment above merely reiterates what is in the URLs in the commit message.

Continuous versions is not an advantage. Coverage is an advantage. If tests pass on Py39, Py311, and Py313 then the chances are very high that Py310 and Py312 will also pass. The setup and running of tests on 5 platforms takes more energy and creates more greenhouse gases than 3 for a negligible benefit. This PR does not want to be more consumptive than the code that it replaces.

If yaml does not need the quotes then yaml does not need the quotes.


steps:
- uses: actions/checkout@v4
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@v3
uses: actions/setup-python@v5
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change @v3 --> @v5 LGTM!

with:
python-version: ${{ matrix.python-version }}
- name: Install Dependencies
Expand Down
Loading