add diagnostic checks to require or suggest .env file #11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abacaphiliac
force-pushed
the
diagnostics
branch
from
f430a69 to
973bab2
Compare
|
I think this is a perfect solution to support both cases, required and non-required |
|
we'll still need your suggestion, to optionally load the file if it exists and/or to catch and ignore the exceptions if the file does not exist. |
|
Yep. I really like the proxy method solution that you suggested, should we go for that one? |
|
@chris-fa yes please |
abacaphiliac
force-pushed
the
diagnostics
branch
4 times, most recently
from
1902fa0 to
7bac417
Compare
…ot exist. default diagnostic requires the file, but the application can override to warn. applications can provide custom factories to override the .env filename and path.
abacaphiliac
force-pushed
the
diagnostics
branch
from
7bac417 to
7ec32a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add diagnostic checks to require .env file and to warn if file does not exist. default diagnostic requires the file, but the application can override to warn. applications can provide custom factories to override the .env filename and path.