fix(log-level-config): exact duration match should return the correct level #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@holtkamp would you mind taking a look at this? |
|
On vacation now, so might take some time before I have time to have a good look... |
|
@holtkamp thanks, enjoy your time off! : ) |
holtkamp
reviewed
Jan 31, 2020
| @@ -65,6 +65,11 @@ private function determineApplicableLogLevel(float $durationInSeconds) : ?string | |||
| //Acquire a common / non-associative array with all the thresholds | |||
| $durationThresholds = array_values($this->logLevelMapping); | |||
|
|
|||
| $exactDurationMatch = array_search($durationInMilliseconds, $this->logLevelMapping); | |||
There was a problem hiding this comment.
- this can/should be done "as early as possible" in the function?
- What is the chance that a duration (float) is exactly matched in a real-world situation? I think that chance is near 0... So what justifies this check? Being able to test it?
There was a problem hiding this comment.
- What is the chance that a duration (float) is exactly matched in a real-world situation? I think that chance is near 0... So what justifies this check? Being able to test it?
i agree that it is near 0. i wouldn't say that the justification is testability, rather accuracy. i tested an edge and the value i expected to get was the not the actual value.
- this can/should be done "as early as possible" in the function?
i think you're correct in assuming the chances are near 0. would this be more palatable at the very end of the function? before null is returned?
There was a problem hiding this comment.
You mention two very valid points 😉. Indeed, moving the "exact match" scenario to the end seems a good place for such edge case 👍
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.