-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/word addressable memory #509
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
moodlezoup
force-pushed
the
feat/word-addressable-memory
branch
from
November 22, 2024 17:40
b97a1df
to
8dacbdd
Compare
moodlezoup
force-pushed
the
feat/word-addressable-memory
branch
from
November 22, 2024 19:13
d9bde5f
to
137bcf1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements "word-addressable" memory for Jolt.
The RISC-V VM spec itself doesn't disallow access to unaligned memory addresses, but notes that implementations may only support aligned memory accesses. In this PR, we add constraints to enforce aligned loads/stores. This allows us to replace halfword and byte loads/stores (i.e. SB, SH, LB, LBU, LH, LHU) with "virtual sequences" (similar to those we use for division/remainder instructions) which emulate their behavior using a combination of bitops and SW/LW.
This improves prover performance and simplifies the code significantly.
Will update docs in a follow-up PR.