Add job 'docker' to Travis CI #1285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 22, 2019 04:42
nakengelhardt
added
the
discuss
cliffordwolf
removed
the
discuss
|
Due to limited time we can use for Travis build, we are not able to build docker image on each commit. |
|
@mmicko, I understand that. Precisely, in org GHDL we moved from Travis to GitHub Actions due to the time limit (50min vs 6h). That's not a problem with GHDL itself, but yosys, nextpnr, etc. might take longer than 50min if tests are executed too. Anyway, this PR was just an excuse to bring up the discussion, since it would be almost useless anyway. I'd be glad if you could please have a look at #1287, which is the relevant issue indeed. See also librecores/docker-images#33 and ghdl/docker#21. |
|
@eine Thank you for feedback. We are working on new build/test environment, and will keep this in mind. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref #1152
This PR adds a job named 'docker' to the Travis CI configuration file. In this job, the docker image is built. This is useful to ensure that the image is buildable. However, it is not pushed anywhere. Hence, users willing to use it need to build it themselves.