Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define custom hooks for transformer when liberated data is ready for transformation #183

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

ashfame
Copy link
Member

@ashfame ashfame commented Dec 19, 2024

This PR fixes the issue in #182

@psrpinto identified the issue that transformations run right after post is saved since we were using save_post hook and that happens before post meta were saved.

So now we define custom hooks for transformations that we ourselves invoke for transformations to run.

Currently there is another issue, that's preventing it from successfully testing it, but if you swap out playground instance from playground.wordpress.net to pg.ashfame.com then it works.

@ashfame ashfame requested a review from psrpinto December 19, 2024 15:36
@ashfame ashfame self-assigned this Dec 19, 2024
Copy link
Member

@psrpinto psrpinto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@psrpinto psrpinto merged commit 5cd2291 into trunk Dec 19, 2024
3 checks passed
@psrpinto psrpinto deleted the fix_182 branch December 19, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants