Update "Edit site" admin bar link to open Site Editor at top level

[dhananjaykuber]

Fixes #63785

What?

This PR updates the "Edit site" admin bar control to consistently open the Site Editor at the top level, rather than opening the specific template editing view of the current page.

Why?

This change is necessary to improve user experience and consistency within the WordPress editor. Currently, the "Edit site" control behaves unpredictably, dropping users into various levels of the Site Editor depending on the page they're viewing. This can be disorienting and makes the control less effective as an entry point to the Site Editor.

By making this change, we align the behavior with the "Editor" control in the WP Admin > Appearance menu, providing a more predictable and consistent experience for users.

How?

The implementation involves modifying the link destination of the "Edit site" admin bar control. Instead of linking to the specific template editing view, it will now link to the top-level Site Editor page.

$wp_admin_bar->add_node(
	array(
	        'id'    => 'site-editor',
		'title' => __( 'Edit site' ),
		'href'  => admin_url( 'site-editor.php' ),
	)
);

Testing Instructions

1. Ensure you're using a block-based theme.
2. Visit different pages on your site's front-end (homepage, a blog post, a static page, etc.).
3. Click the "Edit site" link in the admin bar for each of these pages.
4. Verify that regardless of which page you're on, clicking "Edit site" always takes you to the top-level Site Editor view.
5. Confirm that you're not dropped into a specific template editing view.

Screenshots or screencast

Screen.Recording.2024-07-23.at.11.51.31.AM.mov

[github-actions]

The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the props-bot label.

Unlinked Accounts

The following contributors have not linked their GitHub and WordPress.org accounts: @markhowellsmead.

Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases.

If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message.

Unlinked contributors: markhowellsmead.

Co-authored-by: dhananjaykuber <[email protected]>
Co-authored-by: carolinan <[email protected]>
Co-authored-by: richtabor <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: ndiego <[email protected]>
Co-authored-by: bph <[email protected]>
Co-authored-by: sethrubenstein <[email protected]>
Co-authored-by: bacoords <[email protected]>
Co-authored-by: andreawetzel <[email protected]>
Co-authored-by: colorful-tones <[email protected]>
Co-authored-by: luminuu <[email protected]>
Co-authored-by: annezazu <[email protected]>
Co-authored-by: paaljoachim <[email protected]>
Co-authored-by: JosVelasco <[email protected]>
Co-authored-by: unscripted <[email protected]>
Co-authored-by: jorgefilipecosta <[email protected]>
Co-authored-by: ptesei <[email protected]>

To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook.

[carolinan]

This needs to be changed in the 6.7 folder, not 6.6.

[richtabor]

@dhananjaykuber do you mind addressing the feedback? Thanks!

[carolinan]

Hi
Since 6.7 has already been released, this folder can't be used. It needs to be in a folder for the next major release.

[dhananjaykuber]

Hi @carolinan,
Thank you for pointing that out. I’ll ensure that this is added to the folder for the next major release.