-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E2E: Fix artifacts handling in CI #61338
Merged
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -53,24 +53,51 @@ jobs: | |
|
||
- name: Archive debug artifacts (screenshots, traces) | ||
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
if: always() | ||
if: ${{ !cancelled() }} | ||
with: | ||
name: failures-artifacts | ||
name: failures-artifacts--${{ matrix.part }} | ||
path: artifacts/test-results | ||
if-no-files-found: ignore | ||
|
||
- name: Archive flaky tests report | ||
uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3 | ||
if: always() | ||
if: ${{ !cancelled() }} | ||
with: | ||
name: flaky-tests-report | ||
name: flaky-tests-report--${{ matrix.part }} | ||
path: flaky-tests | ||
if-no-files-found: ignore | ||
|
||
merge-artifacts: | ||
name: Merge Artifacts | ||
if: ${{ !cancelled() }} | ||
needs: [e2e-playwright] | ||
runs-on: ubuntu-latest | ||
outputs: | ||
has-flaky-test-report: ${{ !!steps.merge-flaky-tests-reports.outputs.artifact-id }} | ||
steps: | ||
- name: Merge failures artifacts | ||
uses: actions/upload-artifact/merge@v4 | ||
# Don't fail the job if there aren't any artifacts to merge. | ||
continue-on-error: true | ||
with: | ||
name: failures-artifacts | ||
# Retain the merged artifacts in case of a rerun. | ||
pattern: failures-artifacts* | ||
delete-merged: true | ||
|
||
- name: Merge flaky tests reports | ||
id: merge-flaky-tests-reports | ||
uses: actions/upload-artifact/merge@v4 | ||
continue-on-error: true | ||
with: | ||
name: flaky-tests-report | ||
pattern: flaky-tests-report* | ||
delete-merged: true | ||
|
||
report-to-issues: | ||
name: Report to GitHub | ||
needs: [e2e-playwright] | ||
if: ${{ always() }} | ||
needs: [merge-artifacts] | ||
if: ${{ needs.merge-artifacts.outputs.has-flaky-test-report == 'true' }} | ||
runs-on: ubuntu-latest | ||
steps: | ||
# Checkout defaults to using the branch which triggered the event, which | ||
|
@@ -81,24 +108,20 @@ jobs: | |
show-progress: ${{ runner.debug == '1' && 'true' || 'false' }} | ||
|
||
- uses: actions/[email protected] | ||
id: download_artifact | ||
# Don't fail the job if there isn't any flaky tests report. | ||
continue-on-error: true | ||
with: | ||
name: flaky-tests-report | ||
path: flaky-tests | ||
|
||
- name: Setup Node.js and install dependencies | ||
if: ${{ steps.download_artifact.outcome == 'success' }} | ||
uses: ./.github/setup-node | ||
|
||
- name: Npm build | ||
if: ${{ steps.download_artifact.outcome == 'success' }} | ||
# TODO: We don't have to build the entire project, just the action itself. | ||
run: npm run build:packages | ||
|
||
- name: Report flaky tests | ||
if: ${{ steps.download_artifact.outcome == 'success' }} | ||
uses: ./packages/report-flaky-tests | ||
with: | ||
repo-token: '${{ secrets.GITHUB_TOKEN }}' | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's the difference here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
always()
causes the step to be always executed, even when the job is cancelled, which I don't think we need. Using!cancelled()
will skip it if the job is cancelled.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the clarification!