Verse Block: Prevent text overflow off-screen when the previous block has float #45221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
commented
Oct 22, 2022
| @@ -2,4 +2,8 @@ pre.wp-block-verse { | |||
| font-family: inherit; | |||
| overflow: auto; | |||
| white-space: pre-wrap; | |||
|
|
|||
| // Prevent text overflow off-screen when the previous block has float. | |||
| min-width: 1em; | |||
There was a problem hiding this comment.
This is a trick to prevent the text from being cut off. Without this property, characters will be cut off when the width of the verse text is less than one character.
|
Size Change: +71 B (0%) Total Size: 1.84 MB
ℹ️ View Unchanged
|
t-hamano
force-pushed
the
fix/verse-block-overflow
branch
from
7539ab8 to
c8230d6
Compare
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @kavyagokul. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
t-hamano
force-pushed
the
fix/verse-block-overflow
branch
from
c8230d6 to
ddf21b7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #44924
What?
This PR fixes a problem with verse text being pushed off the screen at mobile sizes when a block with a float applied is placed before the verse block.
Why?
My understanding is that wrapping is intentionally prohibited, as was done in #9584.
This makes sense, but I believe that wrapping should be allowed if the text overflows the container.
How?
I have added
word-break:bread-word;to allow for wrapping if the screen width is such that the text overflows.Screenshots or screencast
On trunk
Confirm that the verse text is pushed out of view when the screen width is small.
Screencast: Verse with left-aligned image on trunk
trunk_left.mp4
Screencast: Verse with right-aligned image on trunk
trunk_right.mp4
On this branch
Confirm that the text wraps just before the verse text becomes invisible.
Screencast: Verse with left-aligned image on this branch
branch_left.mp4
Screencast: Verse with right-aligned image on this branch
branch_right.mp4