Add some improvements to the ISO pattern matching #343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thanks a lot! Would it be possible to test somehow if the data is Joliet or not? I'm completely okay with having it in there but it shouldn't break the pattern for files that don't use it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily it parses all volume descriptors and not just the first one. To do that it always allocates enough padding to reach a length of 2 KiB.
I also tried adding support for the supplementary volume descriptors assuming that it is using Joliet. I'm not sure if that second part fits the code quality of this repository and I can separate it into another pull request if requested: It might contain other encodings depending in the contents of the escape sequences.