Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add python script to generate index-instructions #1241

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Conversation

binji
Copy link
Member

@binji binji commented Aug 28, 2020

The index-instructions table is particularly annoying to update, since
and it requires the tables to line up properly, so it always creates
merge conflicts. This CL adds a Python script that generates it instead.

The index-instructions table is particularly annoying to update, since
and it requires the tables to line up properly, so it always creates
merge conflicts. This CL adds a Python script that generates it instead.
@binji binji requested a review from sbc100 August 28, 2020 20:23
document/core/appendix/gen-index-instructions.py Outdated Show resolved Hide resolved
document/core/appendix/gen-index-instructions.py Outdated Show resolved Hide resolved
document/core/appendix/index-instructions.rst Show resolved Hide resolved
@binji binji merged commit 7ee2139 into master Aug 31, 2020
@binji binji deleted the gen-index-instructions branch August 31, 2020 19:08
@rossberg
Copy link
Member

Yay, more hacks around markdown. :) But why not invoke this in the Makefile and remove the generated file from the repo?

@binji
Copy link
Member Author

binji commented Sep 16, 2020

Sounds good to me. Anyone else want to make this fix? 😄

@sbc100 sbc100 added help wanted good-first-bug A good bug for somebody new to the project wanting to contribute labels Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good-first-bug A good bug for somebody new to the project wanting to contribute help wanted
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants