Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move lifetime to IG attribute #870

Merged
merged 2 commits into from
Oct 24, 2023
Merged

Move lifetime to IG attribute #870

merged 2 commits into from
Oct 24, 2023

Conversation

JensenPaul
Copy link
Collaborator

This was done in the spec several months ago but the explainer was never updated. This change was based on feedback that times in Web APIs should be specified in milliseconds, and moving it to the interest group itself was more extensible.

Note that Chrome continues to accept the lifetime when specified in either place.

@JensenPaul JensenPaul requested a review from caraitto October 20, 2023 14:53
Copy link
Collaborator

@caraitto caraitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to fix this one too:

Indicating whether the origin in the path has permissions to join and/or leave interest groups owned by the domain the request is sent to. Missing permissions are assumed to be false. Since calling `navigator.joinAdInterestGroup()` with a duration of 0 effectively leaves an interest group, `joinAdInterestGroup: true` also allows an origin to call navigator.leaveAdInterestGroup(), even if `leaveadInterestGroup` is missing or is set to false. Note that both `leaveAdInterestGroup()` and `clearOriginJoinedAdInterestGroups()` check the "leaveAdInterestGroup" permission.
"Since calling navigator.joinAdInterestGroup() with a duration of 0 effectively leaves an interest group"

@JensenPaul
Copy link
Collaborator Author

We need to fix this one too:

Indicating whether the origin in the path has permissions to join and/or leave interest groups owned by the domain the request is sent to. Missing permissions are assumed to be false. Since calling `navigator.joinAdInterestGroup()` with a duration of 0 effectively leaves an interest group, `joinAdInterestGroup: true` also allows an origin to call navigator.leaveAdInterestGroup(), even if `leaveadInterestGroup` is missing or is set to false. Note that both `leaveAdInterestGroup()` and `clearOriginJoinedAdInterestGroups()` check the "leaveAdInterestGroup" permission.

"Since calling navigator.joinAdInterestGroup() with a duration of 0 effectively leaves an interest group"

Fixed.

@JensenPaul JensenPaul merged commit 503311e into main Oct 24, 2023
1 check passed
@JensenPaul JensenPaul deleted the JensenPaul-patch-1 branch October 24, 2023 21:20
github-actions bot added a commit that referenced this pull request Oct 24, 2023
SHA: 503311e
Reason: push, by JensenPaul

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to qingxinwu/turtledove that referenced this pull request Oct 25, 2023
SHA: 503311e
Reason: push, by qingxinwu

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants