Incorrect scrubbing of DateTime - Unit test #1377
Closed
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
oh thank you. I was just forking to create this. Now I see that you already did |
|
can u try version 28.7.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is adding the unit test for #1368 and maybe the potential fix?
The issue is that when the culture is set to
en, thelongdate insrc/Verify/Serialization/Scrubbers/DateScrubber_Generated.cscontains one character less than the possible max (the month is 9 instead of 10, 11, or 12). This means that the scrubber does not scrub the first character and therefore returns1DateTime_1in the received file.I was not sure how
src/Verify/Serialization/Scrubbers/DateScrubber_Generated.cswas generated so this change was done manually, however I think this change might need to be applied across all the different cultures?