Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request: Port software water effect to OpenGL renderer. #2165

Open
JulianHeuser opened this issue Apr 21, 2019 · 11 comments
Open

Request: Port software water effect to OpenGL renderer. #2165

JulianHeuser opened this issue Apr 21, 2019 · 11 comments

Comments

@JulianHeuser
Copy link

The water effect used in the software renderer looks arguably better than the OpenGL alternative (examples here: https://twitter.com/joewintergreen/status/1066947983730663424)

Of course it depends on how this effect is coded, and I'm aware that it might not be possible.

@djdallmann
Copy link

Check out the latest BETA and this #1650

@MFKitten
Copy link

I absolutely agree, and there are apparently explosion effects in the software renderer that aren't available in OpenGL too.

@MFKitten
Copy link

@djdallmann did they do anything about the water ripple effect in the latest beta though?

@JulianHeuser
Copy link
Author

I checked, the beta fixes texture scaling but the water effects are the unchanged.

@mleise
Copy link

mleise commented Apr 21, 2019

The texture scaling was doable in a short amount of free time. The ripple effect needs some more hacks on the engine: either copy the software drawn ripple texture to hardware and render that or use pixel shaders (OpenGL 2.0).

@Deus-nsf
Copy link

I second this big time, it would be amazing to see this, plus working gl_overbright, and so the original and faithful vision of the game would be preserved :) (except very minor details)

@DevelopmentDragon
Copy link

Not sure if this is considered necrobumping this, but it would be nice to port that water effect over to OpenGL (as well as figure out how it's done).

@a1batross
Copy link

a1batross commented Nov 19, 2023

It's pretty easy to implement with just reuploading the texture https://github.com/FWGS/xash3d-fwgs/blob/master/ref/gl/gl_warp.c#L857-L1045 (see the end of file)

And performance drop seem to be negligible enough.

@falojazz
Copy link

I second this, the OpenGL water effect is inferior to software.

@captinwill
Copy link

I third this

@Pacman1105
Copy link

I fourth this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

10 participants