NEW: Throw error when extension for inputsystem needed #2101
Conversation
…github.com/Unity-Technologies/InputSystem into throw-error-nda-inputsystem-without-plugin
ritamerkl
requested review from
ekcoh,
Pauliusd01 and
lyndon-unity
and removed request for
ekcoh
| BuildTarget.StandaloneLinux64, | ||
| BuildTarget.tvOS, | ||
| BuildTarget.LinuxHeadlessSimulation, | ||
| BuildTarget.PS5, |
There was a problem hiding this comment.
As mentioned in the U7 version of this PR, PS5 does need an NDA package too so not expecting this in the list.
There was a problem hiding this comment.
Removed in 16479d4
| private static bool IsPluginInstalled() | ||
| { | ||
| var registeredPackages = UnityEditor.PackageManager.PackageInfo.GetAllRegisteredPackages(); | ||
| foreach (var package in registeredPackages) |
There was a problem hiding this comment.
Need to check this takes into account the platforms required plugin. I'm concerned this would pass if p4 package installed and trying to use xbox.
|
|
| public class InputSystemPluginControl | ||
| { | ||
| //At the time of InitializeOnLoad the packages are compiled and registered | ||
| [InitializeOnLoadMethod] | ||
| private static void CheckForExtension() | ||
| { | ||
| ThrowWarningOnMissingPlugin(); | ||
| m_pluginPackageRegistered = false; |
There was a problem hiding this comment.
This isn't granular enough.
See https://github.cds.internal.unity3d.com/unity/neutron/pull/15552#pullrequestreview-889217
Description
Trying to use Input System package on console without the NDA package installed outputs an error message to the user.
The error is thrown in [OnInitializeLoad] and performs on loading a project, on switching platforms and domain reload.
Link to the related ticket.
GXDK extension registeres it self with this PR.
Testing status & QA
Manual testing for Switch platform.
Platforms missing: (which should surface this error without the installed Plugin)
-gamecore
-playstation (4&5)
-switch
-xboxone
Overall Product Risks
Please rate the potential complexity and halo effect from low to high for the reviewers. Note down potential risks to specific Editor branches if any.
Comments to reviewers
Please describe any additional information such as what to focus on, or historical info for the reviewers.
Checklist
Before review:
Changed,Fixed,Addedsections.Area_CanDoX,Area_CanDoX_EvenIfYIsTheCase,Area_WhenIDoX_AndYHappens_ThisIsTheResult.During merge:
NEW: ___.FIX: ___.DOCS: ___.CHANGE: ___.RELEASE: 1.1.0-preview.3.After merge: