Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(EMS-4117-4118): policy - change your answers - broker data mapping #3491

Merged
merged 9 commits into from
Jan 21, 2025
Merged

feat(EMS-4117-4118): policy - change your answers - broker data mapping #3491

merged 9 commits into from
Jan 21, 2025

Conversation

ttbarnes
Copy link
Contributor

Introduction ✏️

This PR updates the "change your answers" functionality for the "policy - broker" section to ensure that:

  • When changing "using a broker" is changed from "yes" to "no", the appropriate "using a broker" fields are wiped.
  • When changing "broker is based in the UK" is changed from "yes" to "no", the appropriate "based in UK" fields are wiped.

Resolution ✔️

  • Update mapSubmittedData to appropriately wipe/nullify USING_BROKER and IS_BASED_IN_UK related fields.
  • Add E2E test coverage.

Miscellaneous ➕

  • Improve E2E naming conventions for "change your broker answers" tests so that they are easier to follow.
  • Fix a typo.

@ttbarnes ttbarnes added enhancement New feature or request tech Technical debt/improvements chore Chore labels Jan 21, 2025
@ttbarnes ttbarnes self-assigned this Jan 21, 2025
abhi-markan
abhi-markan approved these changes Jan 21, 2025
View reviewed changes
Copy link
Collaborator

@abhi-markan abhi-markan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

@abhi-markan abhi-markan merged commit b07cb96 into main-broker-address-lookup Jan 21, 2025
187 of 188 checks passed
@abhi-markan abhi-markan deleted the feat/EMS-4117-4118 branch January 21, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhi-markan abhi-markan abhi-markan approved these changes

Assignees

@ttbarnes ttbarnes

Labels
chore Chore enhancement New feature or request tech Technical debt/improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttbarnes @abhi-markan