-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(EMS-4011-4022): policy - change your answers - broker address #3482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ttbarnes
added
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
chore
Chore
labels
Jan 15, 2025
abhi-markan
requested changes
Jan 21, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏼
abhi-markan
approved these changes
Jan 21, 2025
ttbarnes
merged commit Jan 21, 2025
08883af
into
main-broker-address-lookup
187 of 188 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
chore
Chore
documentation
Improvements or additions to documentation
enhancement
New feature or request
feature
New functionality
tech
Technical debt/improvements
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduction ✏️
This PR updates the user flow to allow for a "change your answers" journey - for changing the "broker address" answer.
Note: the "broker details" form has 4x fields. Depending on the original/origin URL and the current data shape, different redirects need to occur. For example:
Resolution ✔️
E2E
checkPolicySummaryList
address fields to acceptshouldRender
andexpectedValue
params.UI
BROKER_CONFIRM_ADDRESS
"change" and "check and change" routes.BROKER_CONFIRM_ADDRESS
controller to:pageVariables
return aUSE_DIFFERENT_ADDRESS_URL
with or without a "change" suffix.CHECK_YOUR_ANSWERS
if the original URL is a "change" URL.BROKER_DETAILS
controller's POST redirection into it's own helper:getBrokerDetailsPostRedirectUrl
basedInUkRedirectUrl
notBasedInUkRedirectUrl
BROKER_MANUAL_ADDRESS
field links toBROKER_CONFIRM_ADDRESS
, instead ofBROKER_MANUAL_ADDRESS
.SELECT_THE_ADDRESS
field's call togenerateMultipleFieldHtml
only consumes the existingaddressLine1
value. Otherwise, it is incorrect.Miscellaneous ➕
BROKER_FULL_ADDRESS
mocks, to be clearer.usingBroker
params being passed tocy.completeAndSubmitBrokerDetailsForm
.