Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement OAuth2 and others for member authentication #30

Merged
merged 11 commits into from
Dec 23, 2024
Merged

Conversation

No767
Copy link
Member

@No767 No767 commented Dec 23, 2024

Summary

Previously in 2020, Half-Dome was the service responsible for user signups and management. In 2022, that was Firebase. Two years later, it is now SuperTokens. This PR implements the authentication support by using SuperTokens to do the heavy work and pairing everything up to work in the frontend and backend. Below is a diagram from their docs that would explain how this new architecture works:

managed_service_without_dashboard

SuperTokens handles the authentication parts, while the code here implements SuperToken's Python SDK into Kanae. Effectively, a complete user login/signup flow is entirely complete now, and also adds a copy of the member's ID into our own database for relational data.

Caution

Due to SuperTokens not having support for Redoc/Swagger, the API docs are broken as of implementing this PR. There is nothing I can do to fix it, and all I can do is to wait for SuperTokens to come around and properly implement it.

Types of changes

What types of changes does your code introduce to Kanae?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows pass with my new changes
  • This PR does not address a duplicate issue or PR

@No767 No767 merged commit ee49de7 into main Dec 23, 2024
10 checks passed
@No767 No767 deleted the noelle/auth branch December 23, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant