Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite error handlers #28

Merged
merged 1 commit into from
Dec 15, 2024
Merged

Rewrite error handlers #28

merged 1 commit into from
Dec 15, 2024

Conversation

No767
Copy link
Member

@No767 No767 commented Dec 15, 2024

Summary

This PR rewrites error handlers so it basically covers all of it. Now validation errors are considered to be HTTP 404, and any other HTTP errors are processed, and sent back with a response full of the details, status codes and headers. In addition, HTTP 400 is now passed into the responses param within the Kanae subclass so they are now generated on the OpenAPI side.

Types of changes

What types of changes does your code introduce to Kanae?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows pass with my new changes
  • This PR does not address a duplicate issue or PR

@No767 No767 merged commit a919488 into main Dec 15, 2024
11 checks passed
@No767 No767 deleted the noelle/default-errors branch December 15, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant