Fix IDOR Security Vulnerability on /api/resources/get/{resource_id} #1448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ference_idor_1737105809757082 Title: Fix authorization flaw in `download_file_by_id` function to ensure proper user access validation for resource downloads.
ak-gupta89
approved these changes
Jan 22, 2025
|
@ak-gupta89 Thanks for reviewing this. I dont think I can submit it. Let me know if there's additional steps or reviewal required. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Our ZeroPath.com code security tool has found a broken authentication flaw enabling us to view tens of thousands of customers' files (via the publically hosted version). It enabled us to access secrets, business documents, and health information belonging to other users. We have created a patch to enforce authorization when fetching a resource.
We created this PR because we were unable to find a maintainer or a relevant security contact.
Type of change
Checklist