attach
now accepts a nullable View
as it internally is used safely
#35
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
mapView
is treated asNullable
throughoutMapMeAdapter
but when attaching, only aNonNull View
is accepted. Even asSupportMapFragment
is inflated in a parent'sonCreateView
, upon configuration changesonMapReady
might be called beforeonCreateView
of the parent so if the attaching is done inonMapReady
the only possible validView
to pass is the one fetched byrequireView()
but thatView
has yet not been created and anIllegalException
will be thrown.Instead if
getView()
that isNullable
would be allowed, things would work out.