feat : 분류 컴포넌트, 문서 보드 컴포넌트, 푸터 컴포넌트 퍼블리싱 #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ubinquitous
changed the title
jyh071116
approved these changes
Mar 6, 2024
components/Footer/index.tsx
Outdated
Comment on lines
18
to
19
| <div className={styles.information}> | ||
| <span className={styles.information}> |
There was a problem hiding this comment.
div에는 styles.informationBox를 적용하려고했는데 혼동했나보네요!
잘 캐치해주셔서 감사합니다!!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Number
close #11
close #31
close #12
What
부마위키 문서 보드와 푸터, 분류 컴포넌트를 개발했습니다.
How
기본적으로 page 레이아웃 -> 앱 레이아웃으로 정보를 전달하여 분류 컴포넌트와 제목 컴포넌트가 바뀌는 상황이 제일 이상적이지만,
이를 위해 전역 컴포넌트를 라우팅마다 사용하는 것은 과하게 코드의 양이 늘어날 것이라는 우려를 했습니다.
어떤 방식으로 이 문제점을 해결해야할지에 대해서도 생각해보아야할 것 같습니다.
추가적인 의견 있으시면 comment와 함께 남겨주셔도 매우 도움될 것 같습니다!
ScreenShot