-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Migrate ranger docs to v2 layout #153
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I get an error for ranger doc routes where version is not v0
or latest
. The error message says that selectedOption is undefined
.
See these routes for example:
- localhost:3000/ranger/v1/docs/overview
- localhost:3000/ranger/v8/docs/overview
(I am on the docs-rework
branch from #153 in my local clone of the tanstack/ranger
repo.)
I think this is a development-only problem, with a different issue in production. Since local development uses the file system, the version selector doesn't work (different git branches). If you delete the This is for http://localhost:3000/table/v9/docs/introduction For now, I'm just going to change the 'latest' branch back to v1, but this will require a general fix for the new docs layout, rather than a specific fix for ranger. I'd imagine the fix would be something like checking if |
This was an incredibly quick fix to implement :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, works perfectly!
Uses new v2 docs layout and logic
See also: TanStack/ranger#85