Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-router): ensure fetch abort works correctly even with pendingComponent #3181

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leesb971204
Copy link

fixes #3014

Copy link

nx-cloud bot commented Jan 16, 2025

View your CI Pipeline Execution ↗ for commit 178d4a9.

Command Status Duration Result
nx affected --targets=test:eslint,test:unit,tes... ✅ Succeeded 5m 3s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 7s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-16 18:26:50 UTC

Copy link

pkg-pr-new bot commented Jan 16, 2025

Open in Stackblitz

More templates

@tanstack/arktype-adapter

npm i https://pkg.pr.new/@tanstack/arktype-adapter@3181

@tanstack/create-router

npm i https://pkg.pr.new/@tanstack/create-router@3181

@tanstack/directive-functions-plugin

npm i https://pkg.pr.new/@tanstack/directive-functions-plugin@3181

@tanstack/eslint-plugin-router

npm i https://pkg.pr.new/@tanstack/eslint-plugin-router@3181

@tanstack/create-start

npm i https://pkg.pr.new/@tanstack/create-start@3181

@tanstack/history

npm i https://pkg.pr.new/@tanstack/history@3181

@tanstack/react-cross-context

npm i https://pkg.pr.new/@tanstack/react-cross-context@3181

@tanstack/react-router

npm i https://pkg.pr.new/@tanstack/react-router@3181

@tanstack/react-router-with-query

npm i https://pkg.pr.new/@tanstack/react-router-with-query@3181

@tanstack/router-cli

npm i https://pkg.pr.new/@tanstack/router-cli@3181

@tanstack/router-devtools

npm i https://pkg.pr.new/@tanstack/router-devtools@3181

@tanstack/router-generator

npm i https://pkg.pr.new/@tanstack/router-generator@3181

@tanstack/router-plugin

npm i https://pkg.pr.new/@tanstack/router-plugin@3181

@tanstack/router-vite-plugin

npm i https://pkg.pr.new/@tanstack/router-vite-plugin@3181

@tanstack/server-functions-plugin

npm i https://pkg.pr.new/@tanstack/server-functions-plugin@3181

@tanstack/start

npm i https://pkg.pr.new/@tanstack/start@3181

@tanstack/start-plugin

npm i https://pkg.pr.new/@tanstack/start-plugin@3181

@tanstack/valibot-adapter

npm i https://pkg.pr.new/@tanstack/valibot-adapter@3181

@tanstack/virtual-file-routes

npm i https://pkg.pr.new/@tanstack/virtual-file-routes@3181

@tanstack/zod-adapter

npm i https://pkg.pr.new/@tanstack/zod-adapter@3181

commit: 178d4a9

@schiller-manuel
Copy link
Contributor

can you please add a test for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AbortController signal is not called after pendingMs
2 participants