fix(react-router): navigate if redirect is thrown in component #3107
Conversation
|
View your CI Pipeline Execution ↗ for commit b0ae919.
☁️ Nx Cloud last updated this comment at |
schiller-manuel
force-pushed
the
navigate-redirect
branch
from
b9c2da2 to
fb85ed4
Compare
schiller-manuel
force-pushed
the
navigate-redirect
branch
2 times, most recently
from
5d0ea08 to
1a4d32f
Compare
schiller-manuel
force-pushed
the
navigate-redirect
branch
from
1a4d32f to
adf8a33
Compare
| _fromLocation: router.state.location, | ||
| }) | ||
| return ( | ||
| <Navigate {...redirect} replace={true} ignoreBlocker={true} /> |
There was a problem hiding this comment.
What's the rationale for setting replace=true here? Is this something that's required to make it work?
Or is it purely for allowing the user to go from 1 to -1 in a single back button click when considering the user being at position 1 in [ -1 , 0 , 1 ]?
Asking, because if this is not something required on our side to make it functional at runtime, then perhaps, we shouldn't be enforcing replace=true on our side forcing a history replacement. Maybe this should be something the user should opt-in to?
| @@ -252,6 +252,84 @@ describe('redirect', () => { | |||
| expect(await screen.findByText('Final')).toBeInTheDocument() | |||
| expect(window.location.pathname).toBe('/final') | |||
| }) | |||
|
|
|||
| test('when `redirect` is thrown in route component', async () => { | |||
There was a problem hiding this comment.
I think we should test the back button behaviour here since it'd likely be one of the few buttons that'd be front of mind for the end-user to consider immediately hitting next.
No description provided.