Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): allow using enabled when using useQuery().promise #8501

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

KATT
Copy link
Contributor

@KATT KATT commented Jan 4, 2025

Closes #8499

Copy link

nx-cloud bot commented Jan 4, 2025

View your CI Pipeline Execution ↗ for commit 2f69183.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 4m 19s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 10s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-06 18:22:01 UTC

Copy link

pkg-pr-new bot commented Jan 4, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8501

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8501

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8501

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8501

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8501

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8501

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8501

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8501

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8501

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8501

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8501

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8501

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8501

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8501

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8501

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8501

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8501

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8501

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8501

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8501

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8501

commit: 2f69183

@KATT KATT changed the title chore: add test for switching enabled state fix(react): allow using enabled when using useQuery().promise Jan 6, 2025
Comment on lines +1241 to +1251
const observer = new QueryObserver(queryClient, {
queryKey: key,
enabled: false,
queryFn: () => 'data',
})
const results: Array<QueryObserverResult> = []

const success = pendingThenable<void>()

const unsubscribe = observer.subscribe((result) => {
results.push(result)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it should just have a rejected promise when enabled is false instead?

Copy link

codecov bot commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.04%. Comparing base (6184a89) to head (2f69183).
Report is 9 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8501       +/-   ##
===========================================
+ Coverage   46.25%   63.04%   +16.78%     
===========================================
  Files         199      135       -64     
  Lines        7530     4835     -2695     
  Branches     1719     1358      -361     
===========================================
- Hits         3483     3048      -435     
+ Misses       3668     1543     -2125     
+ Partials      379      244      -135     
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.15% <ø> (ø)
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.65% <100.00%> (+0.10%) ⬆️
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.01% <78.57%> (-0.45%) ⬇️
@tanstack/vue-query-devtools ∅ <ø> (∅)

@KATT KATT marked this pull request as ready for review January 6, 2025 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enabling a disabled query does not unsuspend
1 participant