Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(query-core): Improve mutationCache implementation performance #8496

Merged
merged 1 commit into from
Jan 3, 2025
Merged

perf(query-core): Improve mutationCache implementation performance #8496

merged 1 commit into from
Jan 3, 2025

Conversation

TkDodo
Copy link
Collaborator

@TkDodo TkDodo commented Jan 3, 2025 •
edited
Loading

this is #8451 by @gnoff

Closes #8277

@nx-cloud Nx Cloud
Copy link

nx-cloud bot commented Jan 3, 2025 •
edited
Loading

View your CI Pipeline Execution ↗ for commit f7ff771.

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 2m 48s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 1m 9s View ↗

☁️ Nx Cloud last updated this comment at 2025-01-03 14:47:02 UTC

@pkg-pr-new pkg.pr.new
Copy link

pkg-pr-new bot commented Jan 3, 2025

Open in Stackblitz

More templates

@tanstack/angular-query-devtools-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-devtools-experimental@8496

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@8496

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@8496

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@8496

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@8496

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@8496

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@8496

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@8496

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@8496

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@8496

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@8496

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@8496

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@8496

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@8496

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@8496

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@8496

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@8496

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@8496

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@8496

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@8496

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@8496

commit: f7ff771

@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 80.95238% with 8 lines in your changes missing coverage. Please review.

Project coverage is 63.02%. Comparing base (3124193) to head (f7ff771).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #8496       +/-   ##
===========================================
+ Coverage   46.23%   63.02%   +16.79%     
===========================================
  Files         199      135       -64     
  Lines        7512     4825     -2687     
  Branches     1711     1351      -360     
===========================================
- Hits         3473     3041      -432     
+ Misses       3664     1540     -2124     
+ Partials      375      244      -131
Components Coverage Δ
@tanstack/angular-query-devtools-experimental ∅ <ø> (∅)
@tanstack/angular-query-experimental 88.65% <ø> (ø)
@tanstack/eslint-plugin-query ∅ <ø> (∅)
@tanstack/query-async-storage-persister 43.85% <ø> (ø)
@tanstack/query-broadcast-client-experimental ∅ <ø> (∅)
@tanstack/query-codemods ∅ <ø> (∅)
@tanstack/query-core 94.15% <80.95%> (-0.43%) ⬇️
@tanstack/query-devtools 4.78% <ø> (ø)
@tanstack/query-persist-client-core 57.73% <ø> (ø)
@tanstack/query-sync-storage-persister 84.61% <ø> (ø)
@tanstack/react-query 95.54% <ø> (ø)
@tanstack/react-query-devtools 10.00% <ø> (ø)
@tanstack/react-query-next-experimental ∅ <ø> (∅)
@tanstack/react-query-persist-client 100.00% <ø> (ø)
@tanstack/solid-query 78.20% <ø> (ø)
@tanstack/solid-query-devtools ∅ <ø> (∅)
@tanstack/solid-query-persist-client 100.00% <ø> (ø)
@tanstack/svelte-query 87.33% <ø> (ø)
@tanstack/svelte-query-devtools ∅ <ø> (∅)
@tanstack/svelte-query-persist-client 100.00% <ø> (ø)
@tanstack/vue-query 71.45% <ø> (ø)
@tanstack/vue-query-devtools ∅ <ø> (∅)

@TkDodo TkDodo merged commit 19b95c4 into main Jan 3, 2025
8 checks passed
@TkDodo TkDodo deleted the feature/mutation-scopes branch January 3, 2025 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: query-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Next js 15 with dynamicIO: true returned server error
1 participant
@TkDodo