Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add preserve value to field API #444

Merged
merged 7 commits into from
Oct 30, 2023

Conversation

vikaskumar89
Copy link
Contributor

Issue: #417

This PR adds the preserve value property to Field API
Adds deleteField method to form

Copy link
Member

@crutchcorn crutchcorn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This overall looks great! Let's see if we can add tests to:

  • Core/FieldAPI
  • React/FieldAPI

Before merging :)

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 29, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@vikaskumar89 vikaskumar89 reopened this Sep 29, 2023
@vikaskumar89
Copy link
Contributor Author

@crutchcorn please see if this can be merged.

@codecov-commenter
Copy link

codecov-commenter commented Oct 30, 2023

Codecov Report

Attention: 14 lines in your changes are missing coverage. Please review.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Files Coverage Δ
packages/form-core/src/utils.ts 89.13% <ø> (ø)
packages/react-form/src/createFormFactory.ts 100.00% <100.00%> (ø)
packages/react-form/src/formContext.ts 83.33% <ø> (ø)
packages/react-form/src/useForm.tsx 88.88% <100.00%> (ø)
packages/yup-form-adapter/src/tests/utils.ts 100.00% <100.00%> (ø)
packages/yup-form-adapter/src/validator.ts 100.00% <100.00%> (ø)
packages/zod-form-adapter/src/tests/utils.ts 100.00% <100.00%> (ø)
packages/zod-form-adapter/src/validator.ts 100.00% <100.00%> (ø)
packages/react-form/src/useField.tsx 85.71% <71.42%> (ø)
packages/form-core/src/FieldApi.ts 89.01% <89.36%> (+0.81%) ⬆️
... and 1 more

📢 Thoughts on this report? Let us know!.

@crutchcorn crutchcorn merged commit 57bc462 into TanStack:main Oct 30, 2023
5 checks passed
@crutchcorn
Copy link
Member

@vikaskumar89 this was an awesome contribution. Thank you so much for building it and for your immense patience - I'll make sure your next contribution is expedited much faster than this one was. 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants