Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Standard Validator should handle multiple errors on a field #1077

Closed

Conversation

Pascalmh
Copy link
Contributor

As the ZodAdapter is getting deprecated I refactored the failing test to go against the Standard Validator.

see: #943

Copy link

pkg-pr-new bot commented Dec 16, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1077

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1077

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1077

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1077

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1077

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1077

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1077

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1077

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1077

commit: f04d65f

Copy link

nx-cloud bot commented Dec 16, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit f04d65f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx affected --targets=test:sherif,test:knip,test:eslint,test:lib,test:types,test:build,build --parallel=3
✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@Balastrong
Copy link
Member

Returning multiple errors means dealing with arrays instead of simple strings pretty much everywhere. I included this in #1090 and the test seems to be green :)

@Balastrong Balastrong closed this Dec 29, 2024
@Pascalmh Pascalmh deleted the standard-validator-multiple-errors branch December 30, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants