Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove dependency from standard schema and internalize it #1076

Merged

Conversation

Balastrong
Copy link
Member

Attempt number 2 fixing the missing types in validators

Copy link

nx-cloud bot commented Dec 14, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit e90db2f. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


✅ Successfully ran 2 targets

Sent with 💌 from NxCloud.

Copy link

pkg-pr-new bot commented Dec 14, 2024

Open in Stackblitz

More templates

@tanstack/angular-form

npm i https://pkg.pr.new/@tanstack/angular-form@1076

@tanstack/form-core

npm i https://pkg.pr.new/@tanstack/form-core@1076

@tanstack/react-form

npm i https://pkg.pr.new/@tanstack/react-form@1076

@tanstack/solid-form

npm i https://pkg.pr.new/@tanstack/solid-form@1076

@tanstack/lit-form

npm i https://pkg.pr.new/@tanstack/lit-form@1076

@tanstack/valibot-form-adapter

npm i https://pkg.pr.new/@tanstack/valibot-form-adapter@1076

@tanstack/vue-form

npm i https://pkg.pr.new/@tanstack/vue-form@1076

@tanstack/yup-form-adapter

npm i https://pkg.pr.new/@tanstack/yup-form-adapter@1076

@tanstack/zod-form-adapter

npm i https://pkg.pr.new/@tanstack/zod-form-adapter@1076

commit: e90db2f

Copy link

codecov bot commented Dec 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.61%. Comparing base (939f0cc) to head (e90db2f).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##           main    #1076       +/-   ##
=========================================
+ Coverage      0   86.61%   +86.61%     
=========================================
  Files         0       29       +29     
  Lines         0     1158     +1158     
  Branches      0      300      +300     
=========================================
+ Hits          0     1003     +1003     
- Misses        0      142      +142     
- Partials      0       13       +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Balastrong Balastrong changed the title fix: reintroduce mandatory standard schema adapter fix: remove dependency from standard schema and internalize it Dec 14, 2024
@Balastrong Balastrong merged commit 4503caf into TanStack:main Dec 14, 2024
7 checks passed
@Balastrong Balastrong deleted the fix/reintroduce-mandatory-standard-adapter branch December 14, 2024 10:31
@lnhrdt
Copy link

lnhrdt commented Dec 14, 2024

Thank you @Balastrong! Fixed several type errors in our projects that came up in recent versions.

@Balastrong
Copy link
Member Author

That's great, thanks for the feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants