Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

determine AP and MP #230

Merged
merged 5 commits into from
May 8, 2020
Merged

determine AP and MP #230

merged 5 commits into from
May 8, 2020

Conversation

Marco5de
Copy link
Member

@Marco5de Marco5de commented May 8, 2020 •
edited by ottojo
Loading

@Marco5de Marco5de requested review from ottojo, authaldo and csacro May 8, 2020 12:52
@Marco5de Marco5de self-assigned this May 8, 2020
Marco5de
Marco5de commented May 8, 2020
View reviewed changes
src/util/RoundUtils.cpp Outdated Show resolved Hide resolved
@Marco5de Marco5de linked an issue May 8, 2020 that may be closed by this pull request
Charakter BP und AP für Zug festlegen #153
Open
csacro
csacro approved these changes May 8, 2020
View reviewed changes
Copy link
Member

@csacro csacro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue nicht closen (tests feheln) und vllt Kommentar an Issue wegen Behäbigkeit

@Marco5de Marco5de removed a link to an issue May 8, 2020
Charakter BP und AP für Zug festlegen #153
Open
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 8, 2020

SonarCloud Quality Gate failed.

Bug C 1 Bug
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ottojo ottojo merged commit 70eb48d into develop May 8, 2020
@ottojo ottojo deleted the featureDetermineApBp branch May 8, 2020 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csacro csacro csacro approved these changes

@ottojo ottojo ottojo approved these changes

@authaldo authaldo Awaiting requested review from authaldo

Assignees

@Marco5de Marco5de

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Marco5de @ottojo @csacro