-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DeepLearningUI extension #1811
base: main
Are you sure you want to change the base?
Add DeepLearningUI extension #1811
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is interesting and I'm glad you were able to implement it, but I have some questions that were unclear from the readme. First, how is one expected to generate the training data and why is it jpeg? Is there a repository of example training data? Second, how does on use the resulting model? Can you apply it to new data loaded in Slicer?
Great questions. I am currently working on making the data generation process easier by designing another module that will be added to the same extension. The same goes for prediction. So There will be three modules in this extension: 1. Data preparation, 2. Training, 3. Testing. Among which only Training part is done. |
Sounds good, looking forward to seeing it 👍 It probably makes sense to wait for the complete workflow before merging this and then posting on discourse with an example video or tutorial. |
@Connor-Bowley Will you have a look? |
Yes I will take a look at your extension. |
I have added some issues into your extensions git repo that should probably be addressed before merging this. |
@Connor-Bowley Thanks for the help reviewing 🙏 @mturja-vf-ic-bd After reviewing the suggestions linked above, let us know if you have any questions. |
@Connor-Bowley I have addressed your additional comments. |
@mturja-vf-ic-bd The extension is looking good. There are a few checkbox items you still need to address (e.g. the license) |
The checkbox items are addressed. |
The icon URL is incorrect. It should be https://raw.githubusercontent.com/mturja-vf-ic-bd/SlicerDeepLearningUI/main/DeepLearningUI.png |
Similarly the screenshot URL should be https://raw.githubusercontent.com/mturja-vf-ic-bd/SlicerDeepLearningUI/main/screenshot.png One way to get the URL on Chrome is to go to the file in github, right-click on the image, and do "Open image in new tab". That should open the image where you can grab the correct link. |
Before we can more forward with the integration, I suggest you review and address the following issues:
|
34fb2c4
to
d08158d
Compare
d08158d
to
152a982
Compare
We are cleaning out our backlog of open pull requests. We have introduced tiers for extensions, making it easier to add experimental extensions to the index. @mturja-vf-ic-bd if you want your extension to be added to the index then let us know and we can add it as a tier 1. If we don't hear from you then we will close the pull request (but you can reopen it anytime). |
New extension
3d-slicer-extension
GitHub topic so that it is listed here. To edit topics, click the settings icon in the right side of "About" section header and enter3d-slicer-extension
in "Topics" and click "Save changes". To learn more about topics, read https://help.github.com/en/articles/about-topics