Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for HEIF based images #2633

Open
wants to merge 233 commits into
base: main
Choose a base branch
from
Open

Conversation

ynse01
Copy link
Contributor

@ynse01 ynse01 commented Dec 29, 2023

Prerequisites

  • I have written a descriptive pull-request title
  • I have verified that there are no overlapping pull-requests open
  • I have verified that I am following the existing coding patterns and practice as demonstrated in the repository. These follow strict Stylecop rules 👮.
  • I have provided test coverage for my change (where applicable)

Description

This PR is an attempt to start with #1320

Implemented decoding and encoding of images based on a HEIF (ISO/IEC 23008-12:2022) container. These include (amongst others): HEIC, HIF and AVIF.

Please note this PR does NOT add any new compression algorithm to ImageSharp. For now it will take a JPEG thumbnail as its pixel source.
Needless to say, much more work is needed after this PR to reach the goal. I'm try to help there also.

Please do let me know any comments, also on whether to support the HEIF file format in the first place.

@ynse01
Copy link
Contributor Author

ynse01 commented Jan 1, 2025

@JimBobSquarePants Since a few days the Test runs on (at least the Linux) CI servers fails on a missing libgdiplus library file. Is this an issue specific to this branch?
Asking as I didn't change any of the related code.

@stefannikolei
Copy link
Contributor

stefannikolei commented Jan 2, 2025

@JimBobSquarePants Since a few days the Test runs on (at least the Linux) CI servers fails on a missing libgdiplus library file. Is this an issue specific to this branch?

Asking as I didn't change any of the related code.

This is because of usage of Ubuntu:latest. The base image changed and libgdiplus is missing.

I have a fix added to my open pr

This commit fixes the problem 0a7cf55

@JimBobSquarePants
Copy link
Member

@JimBobSquarePants Since a few days the Test runs on (at least the Linux) CI servers fails on a missing libgdiplus library file. Is this an issue specific to this branch?
Asking as I didn't change any of the related code.

This is because of usage of Ubuntu:latest. The base image changed and libgdiplus is missing.

I have a fix added to my open pr

This commit fixes the problem 0a7cf55

Thanks guys, yeah spotted this, just taking a few days break but will get fixes merged soon. Happy New Year!

@stefannikolei
Copy link
Contributor

Enjoy your deserved break

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants