chore: add count based limits for metrics #6738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
|
Build Error! No Linked Issue found. Please link an issue or mention it in the body using #<issue_id> |
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to ea9bcc5 in 3 minutes and 9 seconds
More details
- Looked at
968lines of code in2files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. frontend/src/container/IngestionSettings/MultiIngestionSettings.tsx:58
- Draft comment:
The PR description mentions removing the 'Beta' tag from logs in the sidebar, but the code changes do not address this issue. The changes are related to adding count-based limits for metrics, which is unrelated to the issue described. - Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_Fi3GaFSmluXbjzq4
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
| {/* Count (if usesCount) */} | ||
| {signalCfg.usesCount && | ||
| (limit?.config?.day?.count !== undefined ? ( | ||
| <div style={{ marginTop: 4 }}> |
There was a problem hiding this comment.
Avoid using inline styles. Use external stylesheets, CSS classes, or styled components instead. This issue is also present at line 1197.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/SigNoz/engineering-pod/issues/1951
Summary
Related Issues / PR's
Screenshots
NA
Affected Areas and Manually Tested Areas
Important
Add count-based limits for metrics in
MultiIngestionSettings.tsx, updating UI and types to support this feature.MultiIngestionSettings.tsx.COUNT_MULTIPLIERandSIGNALS_CONFIGto handle count-based limits.handleAddLimitandhandleUpdateLimitto process count limits.MultiIngestionSettings.tsxto include count-based fields.countfield toLimitConfigintypes.ts.LimitSettings,AddLimitProps, andUpdateLimitPropsto support count limits.This description was created by
for ea9bcc5. It will automatically update as commits are pushed.