Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dead attr_writer sort_nodes= #322

Merged
merged 1 commit into from
Jan 2, 2025

Conversation

shopify-codedb[bot]
Copy link
Contributor

This attr_writer appears to be unused and could be removed.

Before approving this pull-request, please double-check that it is indeed unused.

If this code is actually used, please add a comment explaining why and close this pull-request.

@shopify-codedb shopify-codedb bot requested a review from a team as a code owner July 14, 2024 00:26
@shopify-codedb shopify-codedb bot requested review from egiurleo and vinistock July 14, 2024 00:26
@shopify-codedb shopify-codedb bot closed this Dec 23, 2024
@shopify-codedb
Copy link
Contributor Author

This pull request has been closed due to exceeding its auto-close period of 1 month. To remove the code, either re-open and ship this pull request, or create a new PR for the removal from CodeDB.

@KaanOzkan
Copy link
Contributor

Looks unused in Tapioca, although it's a public API I think it's safe to remove.

@KaanOzkan KaanOzkan reopened this Jan 2, 2025
@KaanOzkan KaanOzkan force-pushed the remove-deadcode-rbi-formatter-sort_nodes_ branch from 33c3ca8 to 5e2b701 Compare January 2, 2025 16:28
@KaanOzkan KaanOzkan merged commit a4f9eb0 into main Jan 2, 2025
8 checks passed
@KaanOzkan KaanOzkan deleted the remove-deadcode-rbi-formatter-sort_nodes_ branch January 2, 2025 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant